Skip to content

Fix for undefined exports in NAMESPACE (Fix #345)#350

Open
livisupajares wants to merge 5 commits intoxia-lab:masterfrom
livisupajares:master
Open

Fix for undefined exports in NAMESPACE (Fix #345)#350
livisupajares wants to merge 5 commits intoxia-lab:masterfrom
livisupajares:master

Conversation

@livisupajares
Copy link
Copy Markdown

@livisupajares livisupajares commented Jul 15, 2025 •
edited
Loading

This fixes issue #345 by renaming several exported functions in the NAMESPACE file:

  • Plot.sampletrend to plot.sample.trend
  • RemoveMissingPercent to RemoveMissingByPercent
  • plot_dist to plot.sample.dist

Note that the documentation (man pages) needs to be fixed to reflect the name of these changes in name functions.

@livisupajares
Update .gitignore
51048bf 
Add .DS_Store files
@livisupajares
Fix exported function names in NAMESPACE
36f0821 
Renamed several exported functions in the NAMESPACE file for consistency: 'Plot.sampletrend' to 'plot.sample.trend', 'RemoveMissingPercent' to 'RemoveMissingByPercent', and 'plot_dist' to 'plot.sample.dist'.
@jchmiel4 jchmiel4 mentioned this pull request Jul 17, 2025
Open
@Vincendovich
Copy link
Copy Markdown

Vincendovich commented Jul 22, 2025

it appears that one more function name needs to be replaced
PlotImpVarMeta to PlotImpVarCont

@livisupajares
fix: Update exported function in NAMESPACE
5f661ae 
Replaced export of PlotImpVarMeta with PlotImpVarCont in the NAMESPACE file to reflect the correct function being made available for package users.
@NBordag
Copy link
Copy Markdown

NBordag commented Jul 23, 2025

I ran into the issue #345 and tried this installation:
devtools::install_github("xia-lab/MetaboAnalystR@refs/pull/350/head", build = TRUE, build_vignettes = TRUE, build_manual =T)
but ran into the issue of "... not defined export: PlotImpVarCont" failing the installation.
thx for the help in advance.

@livisupajares
Copy link
Copy Markdown
Author

livisupajares commented Jul 24, 2025

I ran into the issue #345 and tried this installation: devtools::install_github("xia-lab/MetaboAnalystR@refs/pull/350/head", build = TRUE, build_vignettes = TRUE, build_manual =T) but ran into the issue of "... not defined export: PlotImpVarCont" failing the installation. thx for the help in advance.

I fixed the issue, turns out my fork seems to be out of sync so the change from PlotImpVarMeta to PlotImpVarCont hadn't been registered yet so I reverted it back.

Testing the install it doesn't throw me that error anymore.

@NBordag
Copy link
Copy Markdown

NBordag commented Jul 29, 2025

My collegue and I confirm, installation was now possible with the suggested line:
devtools::install_github("xia-lab/MetaboAnalystR@refs/pull/350/head", build = TRUE, build_vignettes = TRUE, build_manual =T)
Thx a ton, Best

@yueguangguangzhanshi
Copy link
Copy Markdown

yueguangguangzhanshi commented Aug 13, 2025

mark

@HannahHisham
Copy link
Copy Markdown

HannahHisham commented Aug 16, 2025

My collegue and I confirm, installation was now possible with the suggested line: devtools::install_github("xia-lab/MetaboAnalystR@refs/pull/350/head", build = TRUE, build_vignettes = TRUE, build_manual =T) Thx a ton, Best

THANKS!!!!!!!

@tfccheng
Copy link
Copy Markdown

tfccheng commented Sep 15, 2025

this issue is still present in v 4.2 installation

@phychoJOE phychoJOE mentioned this pull request Oct 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@livisupajares @Vincendovich @NBordag @yueguangguangzhanshi @HannahHisham @tfccheng